Skip to content

feat: implement SNIP-29 (issue #745) #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 122 commits into from
Oct 23, 2025
Merged

feat: implement SNIP-29 (issue #745) #768

merged 122 commits into from
Oct 23, 2025

Conversation

@Salonii02
Copy link
Contributor

@Salonii02 Salonii02 commented Jun 30, 2025 •
edited by thiagodeev
Loading

Summary

This pull request introduces supporting methods for the SNIP-29 Applicative Paymaster API, enabling off-chain paymaster integration for sponsored and flexible transaction fee payments.
This PR closes #745.

Key Changes

  • A new paymaster pkg was created in the root of the repository to provide a dedicated interface for the paymaster API.
  • It implements all methods from the OpenRPC specification: https://github.com/starknet-io/SNIPs/blob/main/assets/snip-29/paymaster_api.json
    • paymaster_isAvailable
    • paymaster_getSupportedTokens
    • paymaster_buildTransaction
    • paymaster_executeTransaction
    • paymaster_trackingIdToLatestHash
  • Mock and integration tests with the AVNU paymaster to assert correctness.
  • New CI workflow to continuously verify the paymaster functionality.
  • New paymaster example in the example folders showing how to use it.

@Salonii02 Salonii02 requested a review from thiagodeev as a code owner June 30, 2025 11:44
@Salonii02 Salonii02 mentioned this pull request Jun 30, 2025
Closed
@thiagodeev thiagodeev moved this to 🔖 To do in [Nubia] Starknet.go Jun 30, 2025
@thiagodeev
Copy link
Collaborator

thiagodeev commented Jul 1, 2025

Thank you @Salonii02!
I'll do my best to review it tomorrow

@thiagodeev
Copy link
Collaborator

thiagodeev commented Jul 2, 2025

Hi @Salonii02!
Unfortunately, due to the proximity of Starknet v0.14.0 + RPC v0.9.0 update in Sepolia, I'll pause the reviews for a few days to release a compliant Starknet.go version ASAP.
Hope you understand 🙌

@Salonii02
Copy link
Contributor Author

Salonii02 commented Jul 5, 2025

Hi @Salonii02! Unfortunately, due to the proximity of Starknet v0.14.0 + RPC v0.9.0 update in Sepolia, I'll pause the reviews for a few days to release a compliant Starknet.go version ASAP. Hope you understand 🙌

Okay Thanks!! No worries, will wait for the review.

@Salonii02
Copy link
Contributor Author

Salonii02 commented Jul 15, 2025

Hi @Salonii02! Unfortunately, due to the proximity of Starknet v0.14.0 + RPC v0.9.0 update in Sepolia, I'll pause the reviews for a few days to release a compliant Starknet.go version ASAP. Hope you understand 🙌

Hey @thiagodeev Did you get chance to review my changes

@thiagodeev
Copy link
Collaborator

thiagodeev commented Jul 15, 2025

Hey! Sorry @Salonii02, not yet. All PR reviews are still paused until the final rpc v0.9 release.
But I can see the CI is failing with some errors. You can fix them in the meantime

@tarrencev
Copy link
Contributor

tarrencev commented Aug 26, 2025

Looking forward to this landing!

@thiagodeev
Copy link
Collaborator

thiagodeev commented Aug 29, 2025

Hey @Salonii02!
I've pushed some commits to the PR, and will be making more hehe. I'm currently working directly on this feature.
I'm leveraging your work. Thanks again!
I'll give you an overview of the changes at the end of my work and a review of yours.

@Salonii02
Copy link
Contributor Author

Salonii02 commented Sep 5, 2025

Hey @Salonii02! I've pushed some commits to the PR, and will be making more hehe. I'm currently working directly on this feature. I'm leveraging your work. Thanks again! I'll give you an overview of the changes at the end of my work and a review of yours.

Okay thanks!! Looking forward to it

@thiagodeev thiagodeev force-pushed the implement-SNIP-29-issue-745 branch 3 times, most recently from a44fda4 to e05372f Compare September 15, 2025 14:14
@thiagodeev thiagodeev force-pushed the implement-SNIP-29-issue-745 branch from d2f2a71 to 1164214 Compare September 18, 2025 19:46
Salonii02 and others added 14 commits September 24, 2025 12:19
@Salonii02 @thiagodeev
adding changes for snip29.
7ca9b6d
@thiagodeev
fix: outdated function name call due to merge with main
1bc1dd6
@thiagodeev
chore: remove new paymaster tests from the mock_test.go file
9a4de8d 
This file is planned to be removed in the future, so no need to add more tests here. We can use the mockgen pkg intead
@thiagodeev
refactor: move paymaster code to a dedicated paymaster pkg
36d971d
@thiagodeev
refactor: update Paymaster client and the NewPaymasterClient() logic
c89995b
@thiagodeev
chore: regenerate paymaster mock
6887e55
@thiagodeev
chore: go mod tidy
5e60153
@thiagodeev
test: add setup function for paymaster tests with mock and integratio…
ea31ab7 
…n environments
@thiagodeev
fix: fix circular import error by removing the paymaster mock and int…
7e8c1ee 
…erface

We are not using this interface anywere, nor the mock
@thiagodeev
refactor: simplify paymaster test setup functions by introducing Mock…
2e36e60 
…Paymaster and removing environment enum
@thiagodeev
test: add IsAvailable method tests for both integration and mock scen…
66b270d 
…arios
@thiagodeev
fix: linter errors + wrong additional parameter in the paymaster RPC …
ac81e9c 
…calls
@thiagodeev
docs: update comments for Paymaster methods and TokenData structure f…
b1df8e1 
…or clarity and consistency
@thiagodeev
test: add GetSupportedTokens method tests and enable parallel executi…
f939221 
…on for existing tests
@thiagodeev
Merge branch 'main' into implement-SNIP-29-issue-745
f7affd4
@thiagodeev
chore: rename ConstructorCalldata to Calldata in AccDeploymentData
913a0d8
@thiagodeev
chore: rename AccDeploymentData to AccountDeploymentData
7aefaf5
@thiagodeev
refactor: change UserTxnType to use int values instead of string
bf5f133
@thiagodeev
refactor: change UserParamVersion to use int values instead of string
918f7e8
@thiagodeev
refactor: change FeeModeType to use int values instead of string
5001df1
@thiagodeev
refactor: change TipPriorityEnum to use int values instead of string
f440b61
@thiagodeev
test: add unit tests for TipPriority type and improve JSON marshaling
3713ca8
@thiagodeev
refactor: update account contract versioning to use CairoVersion type
a521030
@thiagodeev
refactor: update Paymaster client initialization to include context p…
2dbb7d3 
…arameter
@thiagodeev
test: add linter comment to IsAvailable test
0f8a238
@thiagodeev
refactor: update transaction request parameters to use pointer types …
cbb6d20 
…for BuildTransactionRequest and ExecuteTransactionRequest
@thiagodeev
Merge branch 'main' into implement-SNIP-29-issue-745
bae1088
@thiagodeev thiagodeev mentioned this pull request Oct 21, 2025
Merged
@thiagodeev thiagodeev mentioned this pull request Oct 23, 2025
Merged
@thiagodeev thiagodeev mentioned this pull request Oct 23, 2025
Merged
@thiagodeev thiagodeev merged commit 9f00140 into NethermindEth:main Oct 23, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Nubia] Starknet.go Oct 23, 2025
@thiagodeev
Copy link
Collaborator

thiagodeev commented Oct 23, 2025

All the code was reviewed through these five PRs:

The only difference in this PR is the changelog update here

Thanks again @Salonii02!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagodeev thiagodeev thiagodeev left review comments

Assignees

No one assigned

Labels

None yet

Projects

[Nubia] Starknet.go
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

implement SNIP-29

3 participants

@Salonii02 @thiagodeev @tarrencev